Allow an admin user to specify a delegated user. #931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The delegation is specified in an HTTP Header. The header is configured using a separate HttpHeaderPrincipalProvider bean named delegatedPrincipalProvider. If it is configured and a matching header is present in the request, the ServletContainerAuthenticationProvider will replace the userPrincipal in the request with the first principal found in the header. - Added a getFirstPrincipal() convenience method to the HttpHeaderPrincipalProvider. - Added unit tests for the delegated user functionality of the ServletContainerAuthenticationProvider. Check that admins can delegate but regular users cannot. - Added unit test for the getFirstPrincipal method of HttpHeaderPrincipalProvider. - Added an integration test with an On-Behalf-Of header and a mock FAD. Resolves: https://jira.duraspace.org/browse/FCREPO-1790
| @@ -39,7 +39,7 @@ | |||
| * @author Gregory Jansen | |||
| */ | |||
| public final class ServletContainerAuthenticationProvider implements | |||
| AuthenticationProvider { | |||
| AuthenticationProvider { | |||
Code review modifications
|
Needed by fcrepo4/fcrepo-module-auth-webac#49 |
|
Resolved with: b807b2a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delegation is specified in an HTTP Header. The header is configured using a separate HttpHeaderPrincipalProvider bean named delegatedPrincipalProvider. If it is configured and a matching header is present in the request, the ServletContainerAuthenticationProvider will replace the userPrincipal in the request with the first principal found in the header.
Resolves: https://jira.duraspace.org/browse/FCREPO-1790