set data and links nil if not present #1935
Merged
+22
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
fix/nil-data-marshal
branch
from
dbb9ec4 to
0d35cc9
Compare
|
@whyrusleeping can you grab @eminence's test too? eminence@743cd37 -- seems to do more? maybe im wrong |
|
@jbenet look at what the function call i added is doing. |
|
LGTM |
jbenet
added a commit
that referenced
this pull request
Nov 3, 2015
set data and links nil if not present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should address #1925
thanks @eminence for debugging this to root cause!
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com