Big time 👍

@ajs6f a somewhat related question -- there are some lines (currently commented out) related to :

FIXME: removing due to performance problems, esp. w/ many files on federated filesystem

 b.add(create(subject(), HAS_OBJECT_COUNT.asNode(), createLiteral(String
                 .valueOf(getRepositoryCount(repository)))));
 b.add(create(subject(), HAS_OBJECT_SIZE.asNode(), createLiteral(String
                 .valueOf(getRepositorySize(repository)))));

Should those be removed, too?

@awoods @escowles @cbeer What do you think? People want that info, but it is damn hard, and I think we decided that with federation, nearly impossible.

+1 to removing the object count/size here. This would be a great thing to include in webapp-plus, so people who weren't using federation could add it in.

@escowles Are you talking about actually modularizing "all-repo" stats so that people could plug in what they want?

I was thinking we could literally plug in those two lines of code as an optional module. They work fine if you aren't using federation. Of course,people could plug in alternate implementations if they wanted to.

Of course, we could do this in fcrepo4: if there is an appropriate bean injected, then add those properties, otherwise just skip them.

@escowles I would prefer an entirely separate module. I wouldn't mind shoving the Metrics-produced stats in there too.

Normally I do not like dead code, but in this case, it continues to serve as a good reminder. I would suggest leaving this commented-out block around until we actually split the logic into a new, separate module.

@awoods ok, then I will leave this PR as it currently stands; it is ready for review.

@awoods: I've created a ticket for an external module for repository object/byte counts: https://jira.duraspace.org/browse/FCREPO-1820

I think this is ready to go. Any objections?