Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove JCR-, MODE- and ISPN-related data properties #33

Merged
merged 2 commits into from Nov 5, 2015
Merged

Conversation

acoburn
Copy link
Contributor

@acoburn acoburn commented Nov 5, 2015

@ajs6f
Copy link
Contributor

ajs6f commented Nov 5, 2015

A giant 👍 to this.

@ruebot
Copy link
Contributor

ruebot commented Nov 5, 2015

@ajs6f you scared me for a second. The email notification had a thumbs down.

@ajs6f
Copy link
Contributor

ajs6f commented Nov 5, 2015

just a typo

@ruebot
Copy link
Contributor

ruebot commented Nov 5, 2015

😄

@acoburn
Copy link
Contributor Author

acoburn commented Nov 5, 2015

@ajs6f there are a lot of properties removed here -- can you just go over them with a fine-toothed comb to make sure I'm not being over-zealous?

@ajs6f
Copy link
Contributor

ajs6f commented Nov 5, 2015

I have looked through them, and I am happy with them gone. Those relating to clustering should never have been there (we have no design for that in the API) and the others are entirely JCR-specific. Terminate with extreme prejudice.

@acoburn
Copy link
Contributor Author

acoburn commented Nov 5, 2015

@ajs6f if you're happy with this as it stands, I'd like to add one more commit to update the lastModified date.

@ajs6f
Copy link
Contributor

ajs6f commented Nov 5, 2015

Sure, but what do you mean my "update"? You mean change it to a different property?

@acoburn
Copy link
Contributor Author

acoburn commented Nov 5, 2015

@ajs6f I actually meant updating the values of owl:versionInfo and owl:priorVersion. See the add-on commit.

@ajs6f
Copy link
Contributor

ajs6f commented Nov 5, 2015

Oh, yeah-yeah.

ajs6f added a commit that referenced this pull request Nov 5, 2015
remove JCR-, MODE- and ISPN-related data properties
@ajs6f ajs6f merged commit 8e3b94f into master Nov 5, 2015
@ajs6f ajs6f deleted the fcrepo-1819 branch November 5, 2015 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants