Code cleanup in ViewHelpers #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| final Optional<String> title = TITLE_PROPERTIES.stream().map(Property::asNode).flatMap(p -> listObjects( | ||
| graph, sub, p).toList().stream()).filter(Node::isLiteral).map(Node::getLiteral).map( | ||
| LiteralLabel::toString).findFirst(); | ||
| return title.orElse(sub.isURI() ? sub.getURI() : sub.isBlank() ? sub.getBlankNodeLabel() : sub.toString()); |
There was a problem hiding this comment.
personally, I find it easier to read if the expressions are on separate lines:
list.stream()
.map(func1)
.flatMap(func2)
.collect(func3);
There was a problem hiding this comment.
Does this make #938 unnecessary? I'm fine with that, but there is a unit test in that PR (for titles containing URIs) that should be pulled in.
There was a problem hiding this comment.
I'm definitely not of the opinion that line-per-call is more readable, but this is a matter of style.
There was a problem hiding this comment.
Hm, does look like a conflict with #938. Can you rebase over this?
There was a problem hiding this comment.
Okay, cool. I'll wait to pull the trigger on #938, which otherwise looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.duraspace.org/browse/FCREPO-1813