allow non-admin users to PUT/POST to create resources #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (exists.test(path) || path.isRoot()) { | ||
| LOGGER.debug("findRolesForPath: {}", path.getString()); | ||
| return nodeService.find(session, path.toString()); | ||
| } else { |
There was a problem hiding this comment.
No else necessary due to the return on line:111.
There was a problem hiding this comment.
you mean?
if (condition) {
return first;
}
return other;
I prefer my formulation, but I don't feel strongly about it.
There was a problem hiding this comment.
That is what I mean... and I am looking out for @ajs6f here, as he seems to have a strong preference.
|
@awoods the format of the conditional block has been changed. |
|
Resolved with: 26d1fcc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://jira.duraspace.org/browse/FCREPO-1809