code formatting cleanup #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've got 2 files with just with formatting changes in this commit, could those be removed. Otherwise this looks good and builds fine for me. |
|
@whikloj , is that a joke? |
|
This builds fine for me. 👍 |
|
Like this? |
|
@acoburn if I offended you in any way. I am truly sorry. |
|
@whikloj my only concern was that you clearly had not looked very closely at the PR -- there were three files with only formatting changes, not two! |
|
@acoburn perhaps I used unclear terminology. I considered the IT changes where you removed the try statements, to be the actual code changes that I was testing. Perhaps I was incorrect. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://jira.duraspace.org/browse/FCREPO-1807
There are no functional changes here, just some cleanup to make the code style more consistent.