suppress JCR types from RDF representation #935
Conversation
| @@ -35,12 +41,25 @@ | |||
|
|
|||
| private static final Model model = createDefaultModel(); | |||
|
|
|||
| private static final Set<URI> managedTypes = of( | |||
There was a problem hiding this comment.
Would it be possible to try to reconcile the following as opposed to propagating more flavors of managed and internal and protected, etc:
FedoraTypesUtils.isProtectedAndShouldBeHidden
FedoraTypesUtils.EXPOSED_PROTECTED_JCR_TYPES
FedoraTypesUtils.isSuppressedProperty
FedoraTypesUtils.isInternalProperty
FedoraTypesUtils.isInternalNode
ManagedRdf.isManagedTriple
ManagedRdf.isManagedMixin
RdfLexicon.isManagedPredicate
RdfLexicon.isManagedPredicateURI
RdfLexicon.managedProperties
RdfLexicon.isManagedNamespace
RdfLexicon.managedNamespaces
There was a problem hiding this comment.
Do we understand what we mean by "managed" and "internal"? Do those qualities overlap?
| /** | ||
| * No public constructor on utility class | ||
| */ | ||
| private ManagedRdf() { | ||
| } | ||
|
|
||
| public static final Predicate<URI> isManagedType = | ||
| p -> managedTypes.contains(p); |
There was a problem hiding this comment.
Just isManagedType = managedTypes::contains. Do we even need the constant?
|
This PR has been updated. A question though -- I could have added many of the jcr-related properties and types to In my opinion, the |
|
👍 to moving all JCR stuff to |
|
Resolved with: 0014cd7 |
Resolves: https://jira.duraspace.org/browse/FCREPO-1541