add guard for non-literal titles

fcrepo · Nov 3, 2015 · a9d945c · a9d945c
1 parent 9d28989
commit a9d945c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/fcrepo-http-commons/src/main/java/org/fcrepo/http/commons/responses/ViewHelpers.java b/fcrepo-http-commons/src/main/java/org/fcrepo/http/commons/responses/ViewHelpers.java
@@ -212,7 +212,10 @@ public String getObjectTitle(final Graph graph, final Node subject) {
             final Iterator<Triple> objects = getObjects(graph, subject, p);
 
             if (objects.hasNext()) {
-                return objects.next().getObject().getLiteral().getLexicalForm();
+                final Node object = objects.next().getObject();
+                if (object.isLiteral()) {
+                    return object.getLiteral().getLexicalForm();
+                }
             }
         }
 

diff --git a/fcrepo-http-commons/src/test/java/org/fcrepo/http/commons/responses/ViewHelpersTest.java b/fcrepo-http-commons/src/test/java/org/fcrepo/http/commons/responses/ViewHelpersTest.java
@@ -250,6 +250,7 @@ private void shouldExtractTitleFromNode( final Property property ) {
     @Test
     public void shouldUseTheObjectUriIfATitleIsNotAvailable() {
         final Graph mem = createDefaultModel().getGraph();
+        mem.add(new Triple(createURI("a/b/c"), DC_TITLE.asNode(), createURI("d/e/f")));
 
         assertEquals("a/b/c", testObj.getObjectTitle(mem, createURI("a/b/c")));