Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipynb in all themes #1783

Merged
merged 10 commits into from Jun 4, 2015
Merged

ipynb in all themes #1783

merged 10 commits into from Jun 4, 2015

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented Jun 3, 2015

Enable mathjax for all ipynb posts/pages.

@Kwpolska
Copy link
Member

Kwpolska commented Jun 3, 2015

👍 for this bit, want to do the other half or can I take it?

@damianavila
Copy link
Member

Seem OK to me...

@ralsina
Copy link
Member Author

ralsina commented Jun 3, 2015

@Kwpolska feel free, I have a cold and code will be worse than usual for a couple of days :-P

@Kwpolska
add needs_ipython_css to global context
c3d5a4e 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
fix #1782 -- detect and apply ipython css
ab8765e 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
Copy link
Member

Kwpolska commented Jun 4, 2015

The other half is now up for review (c3d5a4e + ab8765e).

Also, ipython blogs often want a change in mathjax config (to accept the ugly $e = mc^2$ syntax for math) — we still need that as setup for ipynb (unless you can always do \(e = mc^2\))

@Kwpolska Kwpolska changed the title part of #1782 ipynb in all themes Jun 4, 2015
@Kwpolska Kwpolska added this to the 7.5.0 milestone Jun 4, 2015
@Kwpolska
Merge branch 'master' into start-1782
c13b6bc
@Kwpolska
update IPython CSS (cc @damianavila)
307e2c7 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
Update CHANGES.txt
50d35ec
@Kwpolska
remove some harmful CSS
782ab40 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
document ipynb support
82c5339 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@ralsina
Copy link
Member Author

ralsina commented Jun 4, 2015

Looks good to me. +1

ralsina added a commit that referenced this pull request Jun 4, 2015
@ralsina
Merge pull request #1783 from getnikola/start-1782
7c73f76 
ipynb in all themes
@ralsina ralsina merged commit 7c73f76 into master Jun 4, 2015
@ralsina ralsina deleted the start-1782 branch June 4, 2015 20:31
@damianavila
Copy link
Member

I little bit late, but LGTM too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@damianavila damianavila

Labels
enhancement
Projects
None yet
Milestone
v7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ralsina @Kwpolska @damianavila