New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Galleries as JSON+JS for all themes #1765
Conversation
@Aeyoun this adds JS galleries to base... is that ok with you? Base is your baby :-) The main goal is to let all the other themes just inherit gallery.tmpl and not have to tweak it. |
<meta name="viewport" content="width=device-width"> | ||
<title>My Nikola Site | My Nikola Site</title> | ||
|
||
<link href="assets/css/rst.css" rel="stylesheet" type="text/css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type is not needed for text/css.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought some validator or other complained if it was not there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In any case, I have no idea why this file is in this diff. It's exactly the same in master :-(
|
|
I will take another shot at this, but this bitrot way too much. |
Working on #1764 and #1623