-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promise Based Async Support #21
Conversation
@elia - will be happy to squash if you like what you see here. I can also redo the PR if/when the 3.1/0.8 PR is merged in so that it's easier to see just the async changes. |
Let's do it this way: squash the commits on #19 and I'll push it as a new rspec31 branch (or something similar) the this PR can target that branch instead of master and the real diff becomes intelligible. Sounds good? |
Browser formatter is the more detailed oriented (as compared to text/rake), so go ahead and include stack traces to ease debugging
* Run_examples hack on example group seems to work now
…summary results reflect failures properly * Clean up puts statements
…irst one for the results, and test for it using the old "should make example fail before async block reached" test
…example should be considered complete * Use that to make skip within an example work
Get descendant example groups working with promises (and share code)
…match that) * Run_after_example had code that ran after the hooks, so needed to wrap that in promises
… specs with async before(:each) +after(:each) now work
…ks, and after better promise understanding, do a more literal conversion of begins/rescues/ensures to promises
* Got something that works as long as the around block does not fail, need to figure out how to fix that
…tly rather than evaluating it in the group in commit b0a4659, all of these specs can be streamlined
@elia - done |
…t submodules + Opal append path
Any updates on this? I could use this merged if it looks good. Nice work @wied03 |
It's next on my list (the whole repo) but needing more than 5min of attention I keep delaying it. 😕 |
@elia cool, no rush. Keep up the good work. |
Builds on the Opal 0.8/RSpec 3.1 branch/pull request.
I've updated the README and Changelog to show usage but here is what has changed on a more detailed level: