Implement Float#next_float Float#prev_float #3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| frac, exp = Math.frexp self | ||
|
|
||
| if frac == -0.5 then |
There was a problem hiding this comment.
No need for then here.
jsyeo
force-pushed
the
jsyeo-next-prev-float
branch
from
8fae581
to
0399652
Compare
|
@yorickpeterse fixed! |
| d = EPSILON / 2 | ||
| d = Math.ldexp(d, MIN_EXP - exp) if exp < MIN_EXP | ||
|
|
||
| result_frac = frac + d |
There was a problem hiding this comment.
What does d stand for in this case? This is rather picky but I personally despise single letter variables.
jsyeo
force-pushed
the
jsyeo-next-prev-float
branch
from
0399652
to
c1c2de0
Compare
brixen
added a commit
that referenced
this pull request
May 30, 2015
Implement Float#next_float Float#prev_float
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed MRI's C implementation for this. 馃槄 Let me know if it's alright.