Fcrepo 1556 #21
Fcrepo 1556 #21
Conversation
- ran mvn javadoc:jar and mvn javadoc:test-aggregate, fixed warning, ran until success - added cmds to .travis.yml - build image already in README.md
|
|
||
| script: | ||
| - mvn javadoc:jar | ||
| - mvn javadoc:test-aggregate |
There was a problem hiding this comment.
I think by adding explicit options here for "script" we lose the default behavior and now no longer actually run the tests.
There was a problem hiding this comment.
I was concerned about that as well, but it looks like the default mvn build still runs. Here is the travis build from a similar commit to fcrepo-audit:
https://travis-ci.org/fcrepo4-labs/fcrepo-audit
@mikedurbin, have you tested your theory?
There was a problem hiding this comment.
Yeah, in looking at the log for the build below, I don't see any evidence that it ran tests. Maybe I'm missing something.
https://travis-ci.org/fcrepo4-labs/migration-utils/builds/64485605
There was a problem hiding this comment.
Ok, do I add another maven call with those 2 calls to explicitly run the tests?
There was a problem hiding this comment.
That makes sense.
I was crawling back through old builds and comparing:
- recent: https://travis-ci.org/fcrepo4-labs/migration-utils/builds/64149342
- ~1 month ago: https://travis-ci.org/fcrepo4-labs/migration-utils/builds/61481379
~1 month ago, looks like the tests were being run.
There was a problem hiding this comment.
I see this in the travis build posted above:
https://travis-ci.org/fcrepo4-labs/fcrepo-audit#L89
"mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V"
That must be a default command?
There was a problem hiding this comment.
Yeah, it does that to "install dependencies".
There was a problem hiding this comment.
@mikedurbin, Do you know where travis gets the "-Dmaven.javadoc.skip=true -B -V" part?
There was a problem hiding this comment.
I'm not sure we can configure it... it's a step it perform for all java maven projects before it runs any of the configured scripts. If you don't configure any scripts it runs "mvn test -B", otherwise it runs whatever your scripts are. Since we liked that it ran "mvn test -B", I think adding that to our list is good. It does seem silly that we install skipping tests and javadoc then we build again for javadocs and tests, but perhaps it compartmentalizes the types of errors it might report.
There was a problem hiding this comment.
I've added individual script lines to perform an install and then perform the unit tests before generating the javadoc items. Is this ok?
|
|
||
| script: | ||
| - mvn install | ||
| - mvn test -B |
There was a problem hiding this comment.
Calling mvn install and mvn test is redundant. Probably mvn install -B -V will be adequate.
https://travis-ci.org/fcrepo4-labs/migration-utils/builds/65105204
There was a problem hiding this comment.
Ok, modified to use that one call mvn install -B -V
|
Squashed and merged. |
https://jira.duraspace.org/browse/FCREPO-1556