PUT/POST must fail if triples not persisted #801

whikloj · 2015-05-26T18:28:58Z

ajs6f · 2015-05-26T19:11:56Z

I can't comment on this PR because @whikloj has made it from his clone and not from the fcrepo4 repo, but I don't think you have to explicitly call toString() for an argument to String.format().

awoods · 2015-05-27T18:24:45Z

I am getting test failures when building this PR:

Tests run: 7, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.406 sec <<< FAILURE! - in org.fcrepo.integration.connector.file.BasicReadWriteFedoraFileSystemConnectorIT
testWriteProperty(org.fcrepo.integration.connector.file.BasicReadWriteFedoraFileSystemConnectorIT)  Time elapsed: 0.347 sec  <<< ERROR!
java.lang.Exception: Unexpected exception, expected<javax.jcr.RepositoryException> but was<org.fcrepo.kernel.exception.MalformedRdfException>
        at org.fcrepo.kernel.impl.utils.JcrPropertyStatementListener.assertNoExceptions(JcrPropertyStatementListener.java:179)
        at org.fcrepo.kernel.impl.FedoraResourceImpl.updateProperties(FedoraResourceImpl.java:405)
        at org.fcrepo.integration.connector.file.BasicReadWriteFedoraFileSystemConnectorIT.testWriteProperty(BasicReadWriteFedoraFileSystemConnectorIT.java:74)

testRemoveProperty(org.fcrepo.integration.connector.file.BasicReadWriteFedoraFileSystemConnectorIT)  Time elapsed: 0.009 sec  <<< ERROR!
java.lang.Exception: Unexpected exception, expected<javax.jcr.RepositoryException> but was<org.fcrepo.kernel.exception.MalformedRdfException>
        at org.fcrepo.kernel.impl.utils.JcrPropertyStatementListener.assertNoExceptions(JcrPropertyStatementListener.java:179)
        at org.fcrepo.kernel.impl.FedoraResourceImpl.updateProperties(FedoraResourceImpl.java:405)
        at org.fcrepo.integration.connector.file.BasicReadWriteFedoraFileSystemConnectorIT.testRemoveProperty(BasicReadWriteFedoraFileSystemConnectorIT.java:100)

INFO 14:23:22.694 (ModeShapeRepositoryFactoryBean) Initiating shutdown of ModeShape
INFO 14:23:22.792 (ModeShapeRepositoryFactoryBean) Repository repo undeployed.
INFO 14:23:22.794 (ModeShapeRepositoryFactoryBean) ModeShape Engine has shutdown.

Results :

Tests in error: 
  BasicReadWriteFedoraFileSystemConnectorIT.testRemoveProperty »  Unexpected exc...
  BasicReadWriteFedoraFileSystemConnectorIT.testWriteProperty »  Unexpected exce...

Fail on POST/PUT with out-of-domain RDF

whikloj · 2015-05-27T20:24:22Z

Sorry @ajs6f I always forget to push to fcrepo4, and @awoods I did see this, but I think I was late. I have fixed it here.

ajs6f · 2015-05-28T13:12:58Z

...l-impl/src/main/java/org/fcrepo/kernel/impl/utils/iterators/PersistingRdfStreamConsumer.java

@@ -89,13 +89,15 @@ public boolean apply(final Triple t) {
                            "Discovered a Fedora-relevant subject in triple: {}.",
                            t);
                } else {
-                    LOGGER.debug("Ignoring triple: {}.", t);
+                    LOGGER.error("subject ({}) is not in repository domain.", t.getSubject().toString());


No need to explicitly call toString() here.

whikloj · 2015-08-13T13:55:14Z

This never got closed, how is that @awoods says it.

Resolved with c5a9b37

whikloj added 3 commits May 27, 2015 15:18

Change MalformedRdfException to a RuntimeException

6617c1c

Fail on POST/PUT with out-of-domain RDF

Fix test

015fe1d

Fix file-connector test and remove unnecessary toString.

e4595a1

whikloj force-pushed the FCREPO-1417 branch from c893191 to e4595a1 Compare May 27, 2015 20:22

ajs6f reviewed May 28, 2015
View reviewed changes

whikloj closed this Aug 13, 2015

awoods deleted the FCREPO-1417 branch August 13, 2015 16:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PUT/POST must fail if triples not persisted #801

PUT/POST must fail if triples not persisted #801

whikloj commented May 26, 2015

ajs6f commented May 26, 2015

awoods commented May 27, 2015

whikloj commented May 27, 2015

ajs6f May 28, 2015

whikloj commented Aug 13, 2015

PUT/POST must fail if triples not persisted #801

PUT/POST must fail if triples not persisted #801

Conversation

whikloj commented May 26, 2015

ajs6f commented May 26, 2015

awoods commented May 27, 2015

whikloj commented May 27, 2015

ajs6f May 28, 2015

Choose a reason for hiding this comment

whikloj commented Aug 13, 2015