Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9k has different scoping behavior than MRI #3010

Closed
zachpendleton opened this issue Jun 1, 2015 · 3 comments
Closed

9k has different scoping behavior than MRI #3010

zachpendleton opened this issue Jun 1, 2015 · 3 comments
Labels
core ir jit
Milestone
JRuby 9.0.0.0.rc1

Comments

@zachpendleton
Copy link

Issue w/ test available here: https://gist.github.com/zachpendleton/e7f1352f4bd079daf288

If attr_accessor is called inside a protected or private method, the instance variables inherit the protected or private scope in 9k, but in MRI they inherit the scope of the call site.
@lephyrius
Copy link

👍 I think I got the same problem here.
#2886
But I couldn't create a nice testcase like u.

@headius
Copy link
Member

headius commented Jun 2, 2015

Ah I see. Yes, method bodies should always default to public visibility, I believe.

@headius
Copy link
Member

headius commented Jun 2, 2015

I see the issue... InterpretedIRMethod is always using that method's visibility when preparing the frame. It should just be left as the default public visibility. Fixing.

@headius headius closed this as completed in 2bd4280 Jun 2, 2015
headius added a commit that referenced this issue Jun 2, 2015
@headius
Method scopes default to public visibility for def.
039697c 
See #3010.
@headius headius added this to the JRuby 9.0.0.0.rc1 milestone Jun 2, 2015
headius added a commit to ruby/spec that referenced this issue Jun 3, 2015
@headius @eregon
Method scopes default to public visibility for def.
32dbc10 
See jruby/jruby#3010.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core ir jit
Projects
None yet
Milestone
JRuby 9.0.0.0.rc1
Development

No branches or pull requests
3 participants
@headius @zachpendleton @lephyrius