Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 95a9d886b2c2
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fe8935336c72
Choose a head ref
  • 3 commits
  • 5 files changed
  • 1 contributor

Commits on Jun 2, 2015

  1. Remove invalid assertion in SizedQueue#enq spec. 

    * The subthread can call enque after the pop and before the call to #size.
    @eregon
    eregon committed Jun 2, 2015
    Copy the full SHA
    fdbce44 View commit details

  2. Split the Complex#hash spec into smaller examples.

    @eregon
    eregon committed Jun 2, 2015
    1
    Copy the full SHA
    d32a698 View commit details

  3. Add tags for some obvious failing specs.

    @eregon
    eregon committed Jun 2, 2015
    Copy the full SHA
    fe89353 View commit details
1 change: 0 additions & 1 deletion spec/ruby/library/thread/sizedqueue/shared/enque.rb
View file
Original file line number Diff line number Diff line change
@@ -11,7 +11,6 @@

q.size.should == 1
q.pop.should == :first_element
q.size.should == 0

blocked_thread.join
q.size.should == 1
6 changes: 4 additions & 2 deletions spec/ruby/shared/complex/hash.rb
View file
Original file line number Diff line number Diff line change
@@ -5,10 +5,12 @@
Complex(1).hash.should == Complex(1).hash
Complex(1, 0).hash.should == Complex(1).hash
Complex(1, 1).hash.should == Complex(1, 1).hash
end

Complex(1, 2).hash.should_not == Complex(1, 1).hash
it "is different for different instances" do
Complex(1, 2).hash.should_not == Complex(1, 1).hash
Complex(2, 1).hash.should_not == Complex(1, 1).hash

Complex(1, 2).hash.should_not == Complex(2, 1).hash
Complex(1, 2).hash.should_not == Complex(2, 1).hash
end
end
1 change: 1 addition & 0 deletions spec/tags/ruby/core/complex/hash_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fails:Complex#hash is different for different instances
7 changes: 7 additions & 0 deletions spec/tags/ruby/core/process/daemon_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -21,3 +21,10 @@ fails:Process.daemon when the second argument is non-false does not redirect std
fails:Process.daemon when the second argument is non-false does not redirect stderr to /dev/null
fails:Process.daemon when the second argument is non-false does not redirect stdin to /dev/null
fails:Process.daemon when the second argument is non-false does not close open files
fails:Process.daemon runs at_exit handlers when the daemon exits
fails:Process.daemon when the second argument is not given redirects stdout to /dev/null
fails:Process.daemon when the second argument is not given redirects stderr to /dev/null
fails:Process.daemon when the second argument is false redirects stdout to /dev/null
fails:Process.daemon when the second argument is false redirects stderr to /dev/null
fails:Process.daemon when the second argument is nil redirects stdout to /dev/null
fails:Process.daemon when the second argument is nil redirects stderr to /dev/null
3 changes: 3 additions & 0 deletions spec/tags/ruby/core/time/strftime_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
fails:Time#strftime with %N formats the picoseconds of of the second with %12N
fails:Time#strftime with %z rounds fixed offset to the nearest second
fails:Time#strftime should be able to show the timezone if available
fails:Time#strftime rounds an offset to the nearest second when formatting with %z
fails:Time#strftime with %N formats the picoseconds of the second with %12N