Implemented File birthtime #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some research only darwin seems to support birthtime via st_birhttimespec in the stat struct. See https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man2/stat.2.html and https://github.com/ruby/ruby/blob/fc7711ff17cde31aec0e2c1d29faca264b49da6b/file.c#L829 for reference.
|
I think this is probably okay to merge. I don't know when I'll finish the ffi-io branch and merge it to master (assuming it's acceptable). In the meantime, this solves this particular gap. |
| @@ -1230,6 +1230,10 @@ int main() { return tgetnum(""); } | |||
| @defines << "HAVE_GETTID" | |||
| end | |||
|
|
|||
| if has_function("birthtime", ["sys/stat.h"]) | |||
| @defines << "HAVE_ST_BIRTHTIME" | |||
| end | |||
There was a problem hiding this comment.
Sorry to be picky here, but line 1234 has an extra leading whitespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this pr because I'm not sure if I did it the "right" way.
The configure script checks if on your system in
stat.hthe functionbirthtime()is defined.If it is a
HAVE_ST_BIRTHTIMEmacro is set which can be used in c++ to check whether to returnst_.st_birthtimeas Time Object or return aPrimitives::failure().In the ruby Stat#birthtime method a
NotImplementedErroris raised if the primitive fails.Also updated the specs for the specific platforms, the problem here I'm not sure which platform supports
birthtime()and which don't.Belongs to #3264