make the default repo for corebuilder work #1317
Merged
+34
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func defaultRepo() repo.Repo { | ||
| func defaultRepo() (repo.Repo, error) { | ||
| c := cfg.Config{} | ||
| priv, pub, err := ci.GenerateKeyPairWithReader(ci.RSA, 1024, u.NewTimeSeededRand()) |
There was a problem hiding this comment.
this is not secure. why not use crypto.Rand ? 1024 is not very slow. (unless you're doing it tons)
There was a problem hiding this comment.
yeah, i guess thats true.
whyrusleeping
force-pushed
the
builder-default
branch
from
ba18dac to
8cb34bc
Compare
|
alright, updated. |
|
@whyrusleeping travis fails to build. rebase? |
whyrusleeping
force-pushed
the
builder-default
branch
from
8cb34bc to
aa16d6f
Compare
whyrusleeping
force-pushed
the
builder-default
branch
from
aa16d6f to
6b16981
Compare
jbenet
added a commit
that referenced
this pull request
Jun 3, 2015
make the default repo for corebuilder work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to build an app using an ipfs node, and the NodeBuilder panics if you dont specify a repo because the default repo setting doesnt provide a peerID and private key. So i added that generation logic into this.