fix erroneous xpath #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -94,7 +95,7 @@ public void configure() throws Exception { | |||
| .filter(not(or(header(IDENTIFIER).startsWith(simple("{{audit.container}}/")), | |||
| header(IDENTIFIER).isEqualTo(simple("{{audit.container}}"))))) | |||
| .to("fcrepo:{{fcrepo.baseUrl}}?preferOmit=PreferContainment") | |||
| .setHeader(FCREPO_TRANSFORM).xpath(hasIndexingTransform, String.class, ns) | |||
| .setHeader(FCREPO_TRANSFORM).xpath(hasIndexingTransformation, String.class, ns) | |||
There was a problem hiding this comment.
I would have thought this would have been caught in an integration test.
Does one need to be added?
There was a problem hiding this comment.
The problem was that the fixture used the same incorrect property, and there is already a unit test for this. Short of validating against the indexing ontology (which is where this is defined), I'm not sure that an additional integration test would do anything for us.
There was a problem hiding this comment.
That is to say, the property we're using here is completely arbitrary. It could just as well be ex:foo, but we're using the convention established in the fcrepo-message-consumer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://jira.duraspace.org/browse/FCREPO-1564