Implement Enumerable#{min,max,min_by,max_by} with optional arguments for Ruby 2.2 #3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def min | ||
| min = undefined | ||
| each do | ||
| o = Rubinius.single_block_arg |
There was a problem hiding this comment.
What is o supposed to mean in this case? Can do get rid of the single letter variables?
There was a problem hiding this comment.
I didn't touch the code, but the variable names have been rewritten :)
There was a problem hiding this comment.
Oh I wasn't condemning you for it, but when changing this anyway it would be nice to take care of cases like this :)
kachick
force-pushed
the
implement-min-max-optarg
branch
from
bf37aed
to
8ef28a0
Compare
brixen
added a commit
that referenced
this pull request
Jun 11, 2015
Implement Enumerable#{min,max,min_by,max_by} with optional arguments for Ruby 2.2
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.