Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't warn on private attribute accessors to match CRuby #3002

Closed
wants to merge 1 commit into from
Closed

Don't warn on private attribute accessors to match CRuby #3002

wants to merge 1 commit into from
+2 −6

Conversation

gsamokovarov
Copy link
Contributor

I'm sorry for the back and forth on this one. I introduced it back in
#2637, but CRuby have recently removed the warning in
https://bugs.ruby-lang.org/issues/10967.

@gsamokovarov
Don't warn on private attribute accessors to match CRuby
271d02c 
I'm sorry for the back and forth on this one. I introduced it back in
jruby#2637, but CRuby have recently removed the warning in
https://bugs.ruby-lang.org/issues/10967.
@kares
Copy link
Member

kares commented May 29, 2015

for reference it's the same one as ruby/ruby#849 under MRI

@kares
Copy link
Member

kares commented Jun 4, 2015

put this on master as c30264c ... (all green when rebased) thanks

@kares kares closed this Jun 4, 2015
@kares kares added this to the JRuby 9.0.0.0.rc1 milestone Jun 4, 2015
@gsamokovarov
Copy link
Contributor Author

💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core JRuby 9000
Projects
None yet
Milestone
JRuby 9.0.0.0.rc1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsamokovarov @kares