better next_tick tests

mojolicious · Apr 26, 2015 · 13bc2ca · 13bc2ca
1 parent 5a5e485
commit 13bc2ca
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/lib/Mojo/Reactor.pm b/lib/Mojo/Reactor.pm
@@ -31,7 +31,8 @@ sub watch     { croak 'Method "watch" not implemented by subclass' }
 
 sub _next {
   my $self = shift;
-  while (my $cb = shift @{$self->{next_tick}}) { $self->$cb }
+  my $next = delete $self->{next_tick};
+  for my $cb (@$next) { $self->$cb }
 }
 
 1;

diff --git a/t/mojo/reactor_ev.t b/t/mojo/reactor_ev.t
@@ -150,13 +150,11 @@ is ref $reactor2, 'Mojo::Reactor::Poll', 'right object';
 
 # Ordered next_tick
 my $result = [];
-$reactor->next_tick(sub { push @$result, 1 });
-$reactor->next_tick(sub { push @$result, 2 });
-$reactor->next_tick(sub { push @$result, 3 });
-$reactor->next_tick(sub { push @$result, 4 });
-$reactor->next_tick(sub { push @$result, 5 });
+for my $i (1 .. 50) {
+  $reactor->next_tick(sub { push @$result, $i });
+}
 $reactor->start;
-is_deeply $result, [1, 2, 3, 4, 5], 'right result';
+is_deeply $result, [1 .. 50], 'right result';
 
 # Reset while watchers are active
 $writable = undef;

diff --git a/t/mojo/reactor_poll.t b/t/mojo/reactor_poll.t
@@ -147,13 +147,11 @@ is ref $reactor2, 'Mojo::Reactor::Poll', 'right object';
 
 # Ordered next_tick
 my $result = [];
-$reactor->next_tick(sub { push @$result, 1 });
-$reactor->next_tick(sub { push @$result, 2 });
-$reactor->next_tick(sub { push @$result, 3 });
-$reactor->next_tick(sub { push @$result, 4 });
-$reactor->next_tick(sub { push @$result, 5 });
+for my $i (1 .. 50) {
+  $reactor->next_tick(sub { push @$result, $i });
+}
 $reactor->start;
-is_deeply $result, [1, 2, 3, 4, 5], 'right result';
+is_deeply $result, [1 .. 50], 'right result';
 
 # Reset while watchers are active
 $writable = undef;