Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't relax rest-client dependency #82

Closed
wants to merge 3 commits into from
Closed

Don't relax rest-client dependency #82

wants to merge 3 commits into from

Conversation

aw
Copy link

@aw aw commented Apr 8, 2015

Hi,

It appears the change here 3e0cf76 breaks on JRuby.

The reason I believe is caused by rest-client v1.8+ which adds a new dependency: http-cookie which requires domain_name which requires unf which requires unf_ext which is a native C gem. :rage1:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 95cebfc on aw:dont-relax-rest-client into bb40b39 on lemurheavy:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 95cebfc on aw:dont-relax-rest-client into bb40b39 on lemurheavy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 95cebfc on aw:dont-relax-rest-client into bb40b39 on lemurheavy:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.23%) to 90.71% when pulling 169aed1 on aw:dont-relax-rest-client into bb40b39 on lemurheavy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 9fbde31 on aw:dont-relax-rest-client into bb40b39 on lemurheavy:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 9fbde31 on aw:dont-relax-rest-client into bb40b39 on lemurheavy:master.

@sferik
Copy link
Contributor

sferik commented Apr 18, 2015

Instead of holding back rest-client, I’d rather see this problem solved by creating a Java-native version of unf_ext.

/cc @headius @enebo @knu

@knu
Copy link

knu commented Apr 18, 2015

There is already a Java version of unf, which does not depend on unf_ext.

@sferik
Copy link
Contributor

sferik commented Apr 18, 2015

🆒 In that case, I don’t think think this change is necessary. FWIW, the build is passing on JRuby 1.7.19 without this change.

@knu
Copy link

knu commented Apr 20, 2015

What's the original problem, anyway?

@aw
Copy link
Author

aw commented Apr 20, 2015

Perhaps I wasn't clear.

It's not this gem's build that fails, it's gems that depend on this one which fail (on JRuby only), because of the newer rest-client dependency.

Example: https://travis-ci.org/aw/CacheRules/jobs/57634366

@knu
Copy link

knu commented Apr 20, 2015

I see. I think the problem lies where Gemfile.lock generated by and for CRuby is used for JRuby. The two implementations of ruby often have different sets of dependencies, and in such a case a Gemfile.lock file cannot be shared between them.

In this case, I'd suggest simply removing Gemfile.lock from the repository especially when it is hosting a gem not an application. Here's a nice article to show you why: http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

@aw
Copy link
Author

aw commented Apr 20, 2015

Oh that's interesting.. I didn't know this about the Gemfile.lock. Thanks for the link, I'll try it out and report back.

@aw
Copy link
Author

aw commented Apr 20, 2015

@knu Good catch! I'll close this issue/pr. Thanks for the tip 🌸 🍶

@aw aw closed this Apr 20, 2015
@knu
Copy link

knu commented Apr 20, 2015

Glad it worked! 🍡 🍵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants