New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't relax rest-client dependency #82
Conversation
2 similar comments
This reverts commit 169aed1.
1 similar comment
There is already a Java version of unf, which does not depend on unf_ext. |
🆒 In that case, I don’t think think this change is necessary. FWIW, the build is passing on JRuby 1.7.19 without this change. |
What's the original problem, anyway? |
Perhaps I wasn't clear. It's not this gem's build that fails, it's gems that depend on this one which fail (on JRuby only), because of the newer |
I see. I think the problem lies where Gemfile.lock generated by and for CRuby is used for JRuby. The two implementations of ruby often have different sets of dependencies, and in such a case a Gemfile.lock file cannot be shared between them. In this case, I'd suggest simply removing Gemfile.lock from the repository especially when it is hosting a gem not an application. Here's a nice article to show you why: http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/ |
Oh that's interesting.. I didn't know this about the Gemfile.lock. Thanks for the link, I'll try it out and report back. |
@knu Good catch! I'll close this issue/pr. Thanks for the tip 🌸 🍶 |
Glad it worked! 🍡 🍵 |
Hi,
It appears the change here 3e0cf76 breaks on JRuby.
The reason I believe is caused by
rest-client v1.8+
which adds a new dependency:http-cookie
which requiresdomain_name
which requiresunf
which requiresunf_ext
which is a native C gem.