Deduplicate code and use stdlib in string functions

ShadowNinja · ShadowNinja · commit 3c3887bb198c · 2015-01-03T14:50:16.000-05:00
diff --git a/src/test.cpp b/src/test.cpp
@@ -189,7 +189,7 @@ struct TestUtilities: public TestBase
 		str_replace(test_str, "there", "world");
 		UASSERT(test_str == "Hello world");
 		test_str = "ThisAisAaAtest";
-		str_replace_char(test_str, 'A', ' ');
+		str_replace(test_str, 'A', ' ');
 		UASSERT(test_str == "This is a test");
 		UASSERT(string_allowed("hello", "abcdefghijklmno") == true);
 		UASSERT(string_allowed("123", "abcdefghijklmno") == false);
diff --git a/src/tile.cpp b/src/tile.cpp
@@ -1380,7 +1380,7 @@ bool TextureSource::generateImagePart(std::string part_of_name,
 				return false;
 			}
 
-			str_replace_char(part_of_name, '&', '^');
+			str_replace(part_of_name, '&', '^');
 			Strfnd sf(part_of_name);
 			sf.next("{");
 			std::string imagename_top = sf.next("{");
diff --git a/src/util/string.cpp b/src/util/string.cpp
@@ -22,15 +22,16 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "numeric.h"
 #include "log.h"
 
-#include <sstream>
-#include <iomanip>
-#include <map>
-
 #include "../sha1.h"
 #include "../base64.h"
 #include "../hex.h"
 #include "../porting.h"
 
+#include <algorithm>
+#include <sstream>
+#include <iomanip>
+#include <map>
+
 static bool parseHexColorString(const std::string &value, video::SColor &color);
 static bool parseNamedColorString(const std::string &value, video::SColor &color);
 
@@ -577,3 +578,9 @@ static bool parseNamedColorString(const std::string &value, video::SColor &color
 
 	return true;
 }
+
+void str_replace(std::string &str, char from, char to)
+{
+	std::replace(str.begin(), str.end(), from, to);
+}
+
diff --git a/src/util/string.h b/src/util/string.h

Original file line number	Diff line number	Diff line change
`@@ -1380,7 +1380,7 @@ bool TextureSource::generateImagePart(std::string part_of_name,`
`1380`	`1380`	`return false;`
`1381`	`1381`	`}`
`1382`	`1382`
`1383`		`- str_replace_char(part_of_name, '&', '^');`
	`1383`	`+ str_replace(part_of_name, '&', '^');`
`1384`	`1384`	`Strfnd sf(part_of_name);`
`1385`	`1385`	`sf.next("{");`
`1386`	`1386`	`std::string imagename_top = sf.next("{");`