Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2c7e6012fdef
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6d7368c01317
Choose a head ref
  • 2 commits
  • 7 files changed
  • 1 contributor

Commits on Apr 21, 2015

  1. Verified

    This commit was signed with the committer’s verified signature.
    headius Charles Oliver Nutter
    Copy the full SHA
    042969b View commit details
  2. Copy the full SHA
    6d7368c View commit details

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1491,7 +1491,7 @@ public ProtectedInstanceMethodsNode(ProtectedInstanceMethodsNode prev) {

@Specialization
public RubyArray protectedInstanceMethods(RubyModule module, UndefinedPlaceholder argument) {
return protectedInstanceMethods(module, false);
return protectedInstanceMethods(module, true);
}

@Specialization
@@ -1501,12 +1501,10 @@ public RubyArray protectedInstanceMethods(RubyModule module, boolean includeAnce

return RubyArray.fromObjects(getContext().getCoreLibrary().getArrayClass(),
module.filterMethods(includeAncestors, new RubyModule.MethodFilter() {

@Override
public boolean filter(InternalMethod method) {
return method.getVisibility() == Visibility.PROTECTED;
}

}).toArray());
}
}
@@ -1551,7 +1549,7 @@ public PrivateInstanceMethodsNode(PrivateInstanceMethodsNode prev) {

@Specialization
public RubyArray privateInstanceMethods(RubyModule module, UndefinedPlaceholder argument) {
return privateInstanceMethods(module, false);
return privateInstanceMethods(module, true);
}

@Specialization
@@ -1560,12 +1558,10 @@ public RubyArray privateInstanceMethods(RubyModule module, boolean includeAncest

return RubyArray.fromObjects(getContext().getCoreLibrary().getArrayClass(),
module.filterMethods(includeAncestors, new RubyModule.MethodFilter() {

@Override
public boolean filter(InternalMethod method) {
return method.getVisibility() == Visibility.PRIVATE;
}

}).toArray());
}
}
Original file line number Diff line number Diff line change
@@ -423,8 +423,6 @@ private void initializeConstants() {

objectClass.setConstant(null, "ARGV", argv);

rubiniusModule.setConstant(null, "UNDEFINED", rubiniusUndefined);

final RubyString separator = RubyString.fromJavaString(stringClass, "/");
separator.freeze();

Original file line number Diff line number Diff line change
@@ -2650,6 +2650,11 @@ public RubyNode visitUntilNode(org.jruby.ast.UntilNode node) {

@Override
public RubyNode visitVCallNode(org.jruby.ast.VCallNode node) {
final SourceSection sourceSection = translate(node.getPosition());
if (node.getName().equals("undefined") && sourceSection.getSource().getPath().startsWith("core:/core/")) {
return new ObjectLiteralNode(context, sourceSection, context.getCoreLibrary().getRubiniusUndefined());
}

final org.jruby.ast.Node receiver = new org.jruby.ast.SelfNode(node.getPosition());
final CallNode callNode = new CallNode(node.getPosition(), receiver, node.getName(), null, null);
return visitCallNodeExtraArgument(callNode, null, true, true);
1 change: 0 additions & 1 deletion truffle/src/main/ruby/core.rb
Original file line number Diff line number Diff line change
@@ -19,7 +19,6 @@
require_relative 'core/rubinius/api/shims/rubinius'
require_relative 'core/rubinius/api/shims/thread'
require_relative 'core/rubinius/api/shims/tuple'
require_relative 'core/rubinius/api/shims/undefined'
require_relative 'core/rubinius/api/shims/metrics'
require_relative 'core/rubinius/api/shims/module'

17 changes: 0 additions & 17 deletions truffle/src/main/ruby/core/rubinius/api/shims/undefined.rb

This file was deleted.