GH-1551 - Adding regression specs.

jruby · Apr 21, 2014 · 05865c1 · 05865c1
1 parent 8cd70f6
commit 05865c1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/core/src/main/java/org/jruby/RubyFixnum.java b/core/src/main/java/org/jruby/RubyFixnum.java
@@ -300,7 +300,8 @@ public RubyString to_s(IRubyObject[] args) {
     @JRubyMethod
     @Override
     public RubyString to_s() {
-        RubyString str = getRuntime().newString(String.valueOf(value));
+        ByteList bl = ConvertBytes.longToByteList(value, 10);
+        RubyString str = getRuntime().newString(bl);
         if (getRuntime().is1_9()) str.setEncoding(USASCIIEncoding.INSTANCE);
         return str;
     }

diff --git a/core/src/main/java/org/jruby/util/ConvertBytes.java b/core/src/main/java/org/jruby/util/ConvertBytes.java
@@ -138,7 +138,7 @@ public static final ByteList longToByteList(long i, int radix, byte[] digitmap)
         } while ((i /= radix) > 0);
         if (neg) buf[--pos] = (byte)'-';
 
-        return new ByteList(buf, pos, len - pos, false);
+        return new ByteList(buf, pos, len - pos);
     }
 
     private static final ByteList intToUnsignedByteList(int i, int shift, byte[] digitmap) {

diff --git a/spec/regression/GH-1551_Fixnumto_s_generates_immutable_string.rb b/spec/regression/GH-1551_Fixnumto_s_generates_immutable_string.rb
@@ -0,0 +1,8 @@
+describe "Fixnum#to_s" do
+  it "returns muttable string" do
+    str = 100.to_s
+    str.should == '100'
+    str[0] = '2'
+    str.should == '200'
+  end
+end