Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for blank nodes in HTML UI #785

Closed
wants to merge 1 commit into from
Closed

Conversation

awoods
Copy link

@awoods awoods commented Apr 25, 2015

@ajs6f
Copy link
Contributor

ajs6f commented Apr 27, 2015

Perhaps we can have an IT to prevent regression?

@awoods
Copy link
Author

awoods commented Apr 27, 2015

I would agree if we had an HTML integration test framework that worked.

@ajs6f
Copy link
Contributor

ajs6f commented Apr 27, 2015

The problem was that an exception was being thrown. We don't need to check the actual HTML, just make a request and get a 200.

@acoburn
Copy link
Contributor

acoburn commented Apr 27, 2015

@ajs6f are you suggesting that we should wait on merging this until an integration test is written?

@ajs6f
Copy link
Contributor

ajs6f commented Apr 27, 2015

I would.

@acoburn
Copy link
Contributor

acoburn commented Apr 27, 2015

ok, I'll try to fit this in today.

@ajs6f
Copy link
Contributor

ajs6f commented Apr 27, 2015

Thanks. I think it's worth doing because otherwise, we risk regression as the general bnode problem continues to evolve. We obviously have no test for this now.

@awoods
Copy link
Author

awoods commented Apr 27, 2015

@acoburn, let me know once you start to work on this integration test... and I will do the same if I start to work on it.

@acoburn
Copy link
Contributor

acoburn commented Apr 27, 2015

@awoods sounds good

@acoburn
Copy link
Contributor

acoburn commented Mar 9, 2016

@awoods shall we close this PR? The related ticket is marked as "Closed: Won't Fix"

@awoods awoods closed this Mar 9, 2016
@awoods awoods deleted the fcrepo-1496 branch March 9, 2016 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants