Removing JCR leakage #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume this PR is dependent on: fcrepo/fcrepo#781 |
|
Yes, this PR depends on fcrep4/fcrepo4#781 |
| } | ||
|
|
||
| final HttpResourceConverter subjects = new HttpResourceConverter(session, UriBuilder.fromUri(baseURL)); | ||
| auditResource.replaceProperties(subjects, m, new RdfStream(), containerService); |
There was a problem hiding this comment.
This isn't working for some reason -- I'm digging around in the RDF machinery trying to figure out why, but no luck so far. I did fix the HttpResourceConvertor to use the audit resource URI for UriBuilder.forUri(), but that didn't fix it.
|
I put this in the JIRA ticket, but thought it would be good to have here to: This PR depends on fcrepo/fcrepo#781 (adding FedoraResource.setURIProperty method) and fcrepo/fcrepo#782 (updating DefaultIdentifierTranslator) |
|
Resolved with: ace483a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://jira.duraspace.org/browse/FCREPO-1489