Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 7f28c6785efa
Choose a base ref
...
head repository: jruby/jruby
compare: 7d240aa18018
Choose a head ref
  • 4 commits
  • 3 files changed
  • 1 contributor

Commits on Apr 21, 2015

  1. Always do this check; does not appear to break test_pid anymore. 

    This should help bring popen behavior in line with MRI per
rails/rails#19777.
    @headius
    headius committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    821bb77 View commit details
    Browse the repository at this point in the history

  2. Better argument processing. 

    * Peel off leading env hash
* Peel off options
* Process coercions correctly

Helps get the case from rails/rails#19777 running right.
    @headius
    headius committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    30cd6e8 View commit details
    Browse the repository at this point in the history

  3. Derp.

    @headius
    headius committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    5c93efa View commit details
    Browse the repository at this point in the history

  4. Minor reformat.

    @headius
    headius committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    7d240aa View commit details
    Browse the repository at this point in the history