remove unused strings from binary #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On VC2003/win32, these 2 strings were stored in RW memory in the shared library. They are unused/unreferenced in Time::Piece. Remove them to make the shared library binary smaller.
|
I can merge, but why are we adding a define for NOID? |
|
So that vars copyright and sccsid are compiled out but still remain in source code. Since the strptime code isn't a normal FOSS license, I am not sure we can outright delete those 2 vars from the src code. If you think we can, feel free to delete them. The 2 vars and their data are unused by Time::Piece, and waste space in the final shared library. The vars might be related to http://en.wikipedia.org/wiki/Source_Code_Control_System . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On VC2003/win32, these 2 strings were stored in RW memory in the shared
library. They are unused/unreferenced in Time::Piece. Remove them to make
the shared library binary smaller.