Add superset test for bloomfilters #1100
Closed
+62
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbenet
added
status/in-progress
| @@ -15,6 +15,7 @@ type Filter interface { | |||
| Find([]byte) bool | |||
| Merge(Filter) (Filter, error) | |||
| HammingDistance(Filter) (int, error) | |||
| SupersetOf(Filter) (bool, error) | |||
There was a problem hiding this comment.
I'm thinking this is the wrong way to add these extensions-- they're putting everything into a single interface. I think maybe the container/heap -- http://golang.org/pkg/container/heap/ -- approach is the right one.
So:
func Superset(a, b Filter) (bool, error) {
// return whether a is superset of b
}There was a problem hiding this comment.
the strings package is similar: http://golang.org/pkg/strings/
|
@krl still want this in, or no? Has been siting here for a while. If we want it in, let's reopen and fix it |
|
Juan Batiz-Benet notifications@github.com writes:
No worries, i will probably rewrite anything that depends on this stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last thing i need for now...