Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index file for Blocks #1042

Merged
merged 1 commit into from
Apr 9, 2015
Merged

Index file for Blocks #1042

merged 1 commit into from
Apr 9, 2015
+55 −1

Conversation

KJA1582
Copy link
Contributor

@KJA1582 KJA1582 commented Apr 9, 2015

@fnuecke Bug on backwards linking, ../ does NOT work. You cannot access the blocks index.md from the items index.md and vice versa, they are linked as ../item/index.md and ../block/index.md .
One commit only, as requested :-p

fnuecke added a commit that referenced this pull request Apr 9, 2015
@fnuecke
Merge pull request #1042 from KJA1582/Index-Block
5802418 
Index file for Blocks
@fnuecke fnuecke merged commit 5802418 into MightyPirates:master-MC1.7.10 Apr 9, 2015
@fnuecke
Copy link
Member

fnuecke commented Apr 9, 2015

Great, thanks!

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 9, 2015

No Prob

@KJA1582 KJA1582 deleted the Index-Block branch April 9, 2015 17:09
@KJA1582 KJA1582 restored the Index-Block branch April 9, 2015 17:09
@KJA1582 KJA1582 deleted the Index-Block branch April 9, 2015 17:16
@fnuecke
Copy link
Member

fnuecke commented Apr 9, 2015

Oh, and the crosslinking thinger seems to have been accidentally fixed in the API rework, so yay.

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 9, 2015

Great!

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 9, 2015

@fnuecke Nope, cross linking with ../ to go one layer up still does not work.

@fnuecke
Copy link
Member

fnuecke commented Apr 10, 2015

Huh, works fine for me. Make sure your branch is up-to-date.

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 10, 2015

My branch is at the merge of this PR.

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 10, 2015

@fnuecke

Time of writing: 13:05:15 MESZ

Updated sources to commit cf52f6a.

When trying to jump from the items index to the block index I get following error displayed:

Document not found: doc/%LANGUAGE%/item/../block/index.md

The files are linked in the sources as ../block/index.md

@Vexatos
Copy link
Contributor

Vexatos commented Apr 10, 2015

Same here, but only applies to items->block index, at least for the little bit of testing I have done.

It seems to work fine for all Computronics pages and some OpenComputers pages. Might appear randomly?

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 10, 2015

Doesn't work either way for me. Can't test computronics, not installed in my dev environment

@fnuecke
Copy link
Member

fnuecke commented Apr 10, 2015

It seems to work fine for all Computronics

Hmm, makes me wonder if it might be MC's resource system not liking ..s for paths in JARs. I'll manually resolve those before feeding them to the resource system, hopefully that'll help.

@fnuecke
Copy link
Member

fnuecke commented Apr 10, 2015

OK, done. Please give the latest commit / build 533 a test.

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 10, 2015

Wilco.

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 10, 2015

Confirm, latest commit works!

@fnuecke
Copy link
Member

fnuecke commented Apr 10, 2015

Great, thanks for confirming :-)

Sorry, something went wrong.

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 10, 2015

As always.

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KJA1582 @fnuecke @Vexatos