Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 46fbacf1fd5a
Choose a base ref
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 64caa9f68662
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Apr 10, 2015

  1. String#to_i flag handling should be case-insensitive (e.g. 0X == 0x)

    @vais
    vais committed Apr 10, 2015
    Copy the full SHA
    1de78e1 View commit details

  2. Merge pull request #792 from vais/string 

    String#to_i flag handling should be case-insensitive (e.g. 0X == 0x)
    @meh
    meh committed Apr 10, 2015

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    64caa9f View commit details
Showing with 2 additions and 2 deletions.
  1. +2 −2 opal/corelib/string.rb
4 changes: 2 additions & 2 deletions opal/corelib/string.rb
View file
Original file line number Diff line number Diff line change
@@ -1217,7 +1217,7 @@ def to_f
def to_i(base = 10)
%x{
var result,
string = self,
string = self.toLowerCase(),
radix = #{Opal.coerce_to(`base`, Integer, :to_int)};
if (radix === 1 || radix < 0 || radix > 36) {
@@ -1228,7 +1228,7 @@ def to_i(base = 10)
return 0;
}
string = string.replace(/^(\s*[+-]?)(0[bodx]?)(.+)$/i, function (original, head, flag, tail) {
string = string.replace(/^(\s*[+-]?)(0[bodx]?)(.+)$/, function (original, head, flag, tail) {
switch (tail.charAt(0)) {
case '+':
case '-':