-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Truffle] Add jt test mri command. #2819
Conversation
This is definitely what we want to do next, but I've got quite a few comments on how we want to do this:
This patch would still be useful with just the first two points addressed. |
@chrisseaton The first two points work now, I've ran a little bit of test/unit successfully. The first failure we'll run into here is:
|
Great - I'll merge after pre2 is out. |
[Truffle] Add jt test mri command.
scanf/test_scanfblocks.rb socket/test_basicsocket.rb socket/test_nonblock.rb socket/test_socket.rb stringio/test_stringio.rb strscan/test_stringscanner.rb | ||
thread/test_queue.rb zlib/test_zlib.rb ruby/enc/test_big5.rb ruby/enc/test_cp949.rb ruby/enc/test_emoji.rb ruby/enc/test_euc_jp.rb ruby/enc/test_euc_kr.rb | ||
ruby/enc/test_euc_tw.rb ruby/enc/test_gb18030.rb ruby/enc/test_gbk.rb ruby/enc/test_iso_8859.rb ruby/enc/test_koi8.rb ruby/enc/test_shift_jis.rb ruby/enc/test_utf16.rb | ||
ruby/enc/test_utf32.rb ruby/enc/test_windows_1251.rb] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large literals is almost never a good idea. Especially in a script file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes what we really want to do is add support for running jt test ruby/**/test_.rb
or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or do a proper Dir.glob or have a config file ala MSpec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eregon I think I tracked down how this is generated
./bin/jruby -X+T -e 'mri_test_files = File.readlines("test/mri.index").grep(/^[^#]\w+/).map(&:chomp).join(" ");puts mri_test_files'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, that might be a good replacement (we should have our own index at some point).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eregon BTW there are some workarounds required to apply in this patch if you want to try to use this command: https://gist.github.com/bjfish/1be84623da4a746f4d16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I saw that :)
Patching jruby-core files is not an option, so either we should have shims (for Process.waitall for instance) or we should implement the subset needed for the functionality.
This is just an idea to add a command to run mri tests.
The big args array was derived from https://travis-ci.org/jruby/jruby/jobs/57843253