Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2832da57cf5f
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c2bafc2deafc
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Apr 3, 2015

  1. Removed dead code.

    @nirvdrum
    nirvdrum committed Apr 3, 2015
    Copy the full SHA
    68b59c8 View commit details

  2. [Truffle] Removed dead code.

    @nirvdrum
    nirvdrum committed Apr 3, 2015
    Copy the full SHA
    c2bafc2 View commit details
Showing with 0 additions and 24 deletions.
  1. +0 −9 core/src/main/java/org/jruby/RubyString.java
  2. +0 −15 truffle/src/main/java/org/jruby/truffle/nodes/core/StringNodes.java
9 changes: 0 additions & 9 deletions core/src/main/java/org/jruby/RubyString.java
View file
Original file line number Diff line number Diff line change
@@ -3358,15 +3358,6 @@ public RubyArray split(ThreadContext context, IRubyObject arg0, IRubyObject arg1
return split19(context, arg0, arg1);
}

private void populateCapturesForSplit(Ruby runtime, RubyArray result, Matcher matcher) {
Region region = matcher.getRegion();
for (int i = 1; i < region.numRegs; i++) {
int beg = region.beg[i];
if (beg == -1) continue;
result.append(makeShared19(runtime, beg, region.end[i] - beg));
}
}

private void populateCapturesForSplit(Ruby runtime, RubyArray result, RubyMatchData match) {
for (int i = 1; i < match.numRegs(); i++) {
int beg = match.begin(i);
15 changes: 0 additions & 15 deletions truffle/src/main/java/org/jruby/truffle/nodes/core/StringNodes.java
View file
Original file line number Diff line number Diff line change
@@ -2640,21 +2640,6 @@ public static ByteList downcase(Ruby runtime, ByteList string) {
return runtime.newString(string).downcase(runtime.getCurrentContext()).getByteList();
}

@TruffleBoundary
public static ByteList chompWithString(RubyString string, RubyString stringToChomp) {

String tempString = string.toString();

if (tempString.endsWith(stringToChomp.toString())) {
tempString = tempString.substring(0, tempString.length() - stringToChomp.toString().length());
}

ByteList byteList = ByteList.create(tempString);
byteList.setEncoding(string.getBytes().getEncoding());

return byteList;
}

public static int checkIndex(RubyString string, int index, RubyNode node) {
if (index > string.length()) {
CompilerDirectives.transferToInterpreter();