Collapsing node and fcr:content events to prevent duplicate messages #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he fcr:content property so adding/removing content only produces a single event
| final String id = ev.getIdentifier(); | ||
| // build id from nodepath+user to collapse multiple nodes from adding/removing content nodes | ||
| final String id = ev.getPath().replaceAll("/jcr:content/","/").replaceAll(propPattern,"") | ||
| + "-" + ev.getUserID(); |
There was a problem hiding this comment.
In doing some manual testing, it looks like NonRdfSources named "/book/ucsd:page" are being incorrectly sorted down to "/book".
The approach of tweaking the event path versus in this function which originally was designed to simply extract node identifiers makes me a little nervous.
Do we have an integration test that demonstrates the real issue that this PR is trying to resolve?
…g IT demonstrating only a single event is emitted when content node is added
|
Resolved with: 3de050c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating event machinery to collapse events about content nodes and the fcr:content property so adding/removing content only produces a single event
Fixes https://jira.duraspace.org/browse/FCREPO-1440