Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/yaochunwei patches #129

Closed
wants to merge 4 commits into from
Closed

Conversation

johnmay
Copy link
Member

@johnmay johnmay commented Apr 8, 2015

No description provided.

yapchunwei and others added 4 commits April 8, 2015 11:38
…le three fused 6-membered rings, fused 5-membered ring with two 6-membered rings, two fused 6-membered rings, 5-membered ring fused with 6-membered ring systems. Also generalize the dearomatization of 5-membered ring and 6-membered ring systems.
@johnmay
Copy link
Member Author

johnmay commented Apr 8, 2015

Updated - had manually apply some bits. Also deprecated DeAromTool.

@egonw
Copy link
Member

egonw commented Apr 9, 2015

@johnmay, I've done a clean install, but getting this error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:testCompile (default-testCompile) on project cdk-smsd: Compilation failure: Compilation failure:
[ERROR] /home/egonw/var/Projects/SourceForge/git/cdk/tool/smsd/src/test/java/org/openscience/cdk/smsd/algorithm/rgraph/CDKRMapHandlerTest.java:[70,22] error: non-static method setSource(IAtomContainer) cannot be referenced from a static context

And it seems this class is not changed in any of the commits...

@johnmay
Copy link
Member Author

johnmay commented Apr 9, 2015

Ah but the class it was using did. My bad patching now.

@johnmay
Copy link
Member Author

johnmay commented Apr 9, 2015

Hmm not sure why extra patch isn't showing up.

@egonw
Copy link
Member

egonw commented Apr 9, 2015

No worries; I found it...

@egonw
Copy link
Member

egonw commented Apr 9, 2015

Applied and pushed.

@egonw egonw closed this Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants