Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Truffle] method_added needed for MRI tests #2820

Closed
bjfish opened this issue Apr 10, 2015 · 7 comments
Closed

[Truffle] method_added needed for MRI tests #2820

bjfish opened this issue Apr 10, 2015 · 7 comments
Assignees
@eregon
Milestone
Invalid or Duplicate

Comments

@bjfish
Copy link
Contributor

bjfish commented Apr 10, 2015

The following error occurs when trying to run an MRI test.
Command:

jruby -X+T test/mri/runner.rb -v --color=never --tty=no -q -- ruby/test_alias.rb

Error:

jruby -X+T test/mri/runner.rb -v --color=never --tty=no -q -- ruby/test_alias.rb
/Users/brandonfish/Documents/jruby-mine/test/mri/lib/minitest/unit.rb:1389:in `(singleton-def)': undefined method `method_added' for #<Class:0x114> (NoMethodError)
    from /Users/brandonfish/Documents/jruby-mine/test/mri/lib/minitest/unit.rb:1388:in `TestCase'
    from /Users/brandonfish/Documents/jruby-mine/test/mri/lib/minitest/unit.rb:1242:in `Unit'
    from /Users/brandonfish/Documents/jruby-mine/test/mri/lib/minitest/unit.rb:746:in `MiniTest'
    from /Users/brandonfish/Documents/jruby-mine/test/mri/lib/minitest/unit.rb:12:in `<main>'
    from /Users/brandonfish/Documents/jruby-mine/test/mri/lib/test/unit.rb:5:in `<main>'
    from test/mri/runner.rb:7:in `<main>'
@chrisseaton chrisseaton added this to the truffle-dev milestone Apr 11, 2015
@chrisseaton
Copy link
Contributor

There are quite a lot of these hook methods that we don't call yet.

@bjfish
Copy link
Contributor Author

bjfish commented Apr 12, 2015

The method might be able to be added here without the actual hooks calling them just to get the some tests to run.

@eregon eregon self-assigned this Apr 14, 2015
@eregon
Copy link
Member

eregon commented Apr 14, 2015

I'll do it.

@bjfish
Copy link
Contributor Author

bjfish commented Apr 14, 2015

This method has been added here 70a6330 which resolves the error above.

@bjfish bjfish closed this as completed Apr 14, 2015
@eregon
Copy link
Member

eregon commented Apr 14, 2015

Awesome!

@bjfish
Copy link
Contributor Author

bjfish commented Apr 14, 2015

The hooks still need to be called if you want to look at that @eregon , I only added the method

eregon added a commit that referenced this issue Apr 15, 2015
@eregon
[Truffle] Call method_added when adding a method.
4020d0a 
* See #2820.
@eregon
Copy link
Member

eregon commented Apr 15, 2015

Fixed.

@enebo enebo added this to the Invalid or Duplicate milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eregon eregon

Labels
None yet
Projects
None yet
Milestone
Invalid or Duplicate
Development

No branches or pull requests
4 participants
@enebo @bjfish @eregon @chrisseaton