Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using th instead of td+b and fixing nested divs #74

Merged
merged 1 commit into from Apr 7, 2015
Merged

Using th instead of td+b and fixing nested divs #74

merged 1 commit into from Apr 7, 2015

Conversation

magmax
Copy link
Member

@magmax magmax commented Apr 7, 2015

Two little improvements:

  • I've changed the "td+b" tags by "th" what is more correct, and usually have no visual difference.
  • I've fixed the nested "div" tags when no logo is provided.

@Kwpolska Kwpolska self-assigned this Apr 7, 2015
@Kwpolska
Copy link
Member

Kwpolska commented Apr 7, 2015

Make the same edits in the mako template.

@Kwpolska
Copy link
Member

Kwpolska commented Apr 7, 2015

Merging.

PS. You pushed your change to getnikola/plugins instead of magmax/plugins. Also, please add the e-mail associated with that commit to github (hover on the ? icon)

Kwpolska added a commit that referenced this pull request Apr 7, 2015
@Kwpolska
Merge pull request #74 from magmax/master
b6c3351 
Using th instead of td+b and fixing nested divs
@Kwpolska Kwpolska merged commit b6c3351 into getnikola:master Apr 7, 2015
@magmax
Copy link
Member Author

magmax commented Apr 7, 2015

Sorry, I did it quick and dirty :(
I already fix the commit.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kwpolska Kwpolska

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magmax @Kwpolska