Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic IGW integration, waiting for new hook allowing dynamic content #1029

Closed
wants to merge 9 commits into from
Closed

Conversation

KJA1582
Copy link
Contributor

@KJA1582 KJA1582 commented Apr 7, 2015

Note to self: Don't mess with IntelliJ's Author tab.

YES, Kilian Kurt Hofmann and KJA1528 are the same person.

Kilian Kurt Hofmann and others added 2 commits April 7, 2015 22:23
…nt creation) content from localization files

Currently prints the, to be expected, key of the localization file, e.g.: item.oc.eeprom.usage for documentation on the EEPROM

Filters for OC items and blocks (damn many items)

Updated dependencies as stated at MineMaarten's readme for IGW integration.
@Vexatos
Copy link
Contributor

Vexatos commented Apr 7, 2015

i.e. do not merge yet until this is completely done.

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 7, 2015

Probably best, but the layout of this page is nice to show which changes have been made and where.

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 7, 2015

Also, that way I can easily see if I have some kind of bug which prevent the build from executing nicely. Never know if I set something up differently than travis would do.

@Vexatos
Copy link
Contributor

Vexatos commented Apr 7, 2015

Don't worry about travis, it fails a lot of times, no clue why it's even here.

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 7, 2015

I see that xD, but still, gives a nice feeling having a green dot and not a red one.

@@ -84,5 +83,7 @@ private[oc] class Proxy extends CommonProxy {
FMLCommonHandler.instance.bus.register(HologramRenderer)
FMLCommonHandler.instance.bus.register(PetRenderer)
FMLCommonHandler.instance.bus.register(TextBufferRenderCache)

FMLInterModComms.sendMessage("IGWMod", "li.cil.oc.integration.igwmod.ModIGWMod", "init")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this into ModIGW's init method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ModIGWMod doesn't extend SimpleMod, Its just a base object.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this way the class doesn't even load if IGW isn't there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's supposed to be that way. When IGW is there, it enables IGW support

@fnuecke
Copy link
Member

fnuecke commented Apr 7, 2015

Travis is mostly there for giggles. And because I was curious :P

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 7, 2015

Still passed the build though, makes me happy!

@Vexatos
Copy link
Contributor

Vexatos commented Apr 7, 2015

Bringing the discussion outside the file comments:

For consistency's sake, the IMC message should be sent in Mods so it's still all in one place. But it shouldn't load the class just to send a message to nowhere.

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 7, 2015

Doin' that right now!

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 7, 2015

Moved it. Hopefully the location is fine.

@fnuecke
Copy link
Member

fnuecke commented Apr 7, 2015

It's fine, I'll have another look into what to do with intercom initialized integration when it's time to merge this. But please undo the reformatting of the imports in Proxy.

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 7, 2015

I can't understand WHY IDEA does this anyway. Right on it!

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 7, 2015

Should be fixed now ;)

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 8, 2015

@fnuecke You were quiet active today.

@fnuecke
Copy link
Member

fnuecke commented Apr 8, 2015

Aye, got the manual working, pretty much. If you'd like to help review / edit the entries on the individual items, let me know (I'd really appreciate some help there... :P) so we don't do the same work twice.

@rashdanml
Copy link
Contributor

Forked, Looking through docs, making changes if necessary.

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 8, 2015

If I spot any mistakes, I will report them/fix them. Currently I'm tinkering with getting this to work (somewhat) with IGW, don't expect much though.

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 9, 2015

I'll close this since I messed up my fork really bad :/. Git needs some getting used to.

@KJA1582 KJA1582 closed this Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants