-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic IGW integration, waiting for new hook allowing dynamic content #1029
Conversation
…nt creation) content from localization files Currently prints the, to be expected, key of the localization file, e.g.: item.oc.eeprom.usage for documentation on the EEPROM Filters for OC items and blocks (damn many items) Updated dependencies as stated at MineMaarten's readme for IGW integration.
i.e. do not merge yet until this is completely done. |
Probably best, but the layout of this page is nice to show which changes have been made and where. |
Also, that way I can easily see if I have some kind of bug which prevent the build from executing nicely. Never know if I set something up differently than travis would do. |
Don't worry about travis, it fails a lot of times, no clue why it's even here. |
I see that xD, but still, gives a nice feeling having a green dot and not a red one. |
@@ -84,5 +83,7 @@ private[oc] class Proxy extends CommonProxy { | |||
FMLCommonHandler.instance.bus.register(HologramRenderer) | |||
FMLCommonHandler.instance.bus.register(PetRenderer) | |||
FMLCommonHandler.instance.bus.register(TextBufferRenderCache) | |||
|
|||
FMLInterModComms.sendMessage("IGWMod", "li.cil.oc.integration.igwmod.ModIGWMod", "init") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this into ModIGW
's init method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ModIGWMod doesn't extend SimpleMod, Its just a base object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this way the class doesn't even load if IGW isn't there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's supposed to be that way. When IGW is there, it enables IGW support
Travis is mostly there for giggles. And because I was curious :P |
Still passed the build though, makes me happy! |
Bringing the discussion outside the file comments: For consistency's sake, the IMC message should be sent in |
Doin' that right now! |
Moved it. Hopefully the location is fine. |
It's fine, I'll have another look into what to do with intercom initialized integration when it's time to merge this. But please undo the reformatting of the imports in |
I can't understand WHY IDEA does this anyway. Right on it! |
Should be fixed now ;) |
@fnuecke You were quiet active today. |
Aye, got the manual working, pretty much. If you'd like to help review / edit the entries on the individual items, let me know (I'd really appreciate some help there... :P) so we don't do the same work twice. |
Forked, Looking through docs, making changes if necessary. |
If I spot any mistakes, I will report them/fix them. Currently I'm tinkering with getting this to work (somewhat) with IGW, don't expect much though. |
I'll close this since I messed up my fork really bad :/. Git needs some getting used to. |
Note to self: Don't mess with IntelliJ's Author tab.
YES, Kilian Kurt Hofmann and KJA1528 are the same person.