File event cleanup #767
Closed
File event cleanup #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ora:hasContent property
| @@ -123,6 +124,9 @@ public void remove() { | |||
|
|
|||
| private void addProperty( final FedoraEvent fedoraEvent, final Event ev ) { | |||
| try { | |||
| if (ev.getPath().indexOf(JCR_CONTENT) != -1) { | |||
There was a problem hiding this comment.
Why not simply String.contains() here?
|
Why did the integration test in: not catch this? |
|
@awoods I think the IT doesn't sufficiently capture the way the REST API creates binary content to trigger emitting both nodes. I'll see if I can trigger the bug in the current IT, and if not then I'll add a new IT to fcrepo-webapp (where we have both the REST API and JMS available). |
|
@escowles, thanks. We should hold off on merging this PR until you come back with more IT updates. |
…g code is backed out
|
Resolved with: 6749488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.duraspace.org/browse/FCREPO-1445