Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC doc crafting pics, should be merged soon #1040

Closed
wants to merge 14 commits into from
Closed

OC doc crafting pics, should be merged soon #1040

wants to merge 14 commits into from

Conversation

KJA1582
Copy link
Contributor

@KJA1582 KJA1582 commented Apr 9, 2015

@fnuecke

^Title. Added pics to the Documentation regarding how to craft the item. Should be complete.

@fnuecke
Copy link
Member

fnuecke commented Apr 9, 2015

I really appreciate the effort, which is why it honestly pains me to turn this down. For one, the images are too verbose, if anything it should be the crafting grid, and the crafting grid only. For two, if at all, this will be added as dynamically generated content, because it's much too easy to get out of sync, either from updates or modpacks using custom recipes as the two most obvious examples.
An intermediary solution will probably to allow pressing 'r' while on a page to open NEI with a recipe handler for the item of the currently shown page, or something like that.

Something that does need doing, and AFAIK noone is working on right now would be a block index, i.e. the equivalent to item/index.md for the blocks, if it's OK to steer your motivation a little ;-) [as one single commit, preferably]

Sorry, something went wrong.

@fnuecke fnuecke closed this Apr 9, 2015
@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 9, 2015

I already thoughtnthat The pics are to large, oh well.

I will Look into The block Index.

Single commits are rauher hard when The upstream updaten 10 Times while working on something. I just like to be up to date.

@fnuecke
Copy link
Member

fnuecke commented Apr 9, 2015

Doesn't mean you can't be! Ask your favorite search engine for git squash commits.

Sorry, something went wrong.

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 9, 2015

So my network decided to denie Internet access, and I can't restart it because I'm doing a 300gb backup :/

This means, that I'm stuck with outdated sources (no items/index.md for example) and I also cannot push anything.

If it resolves itself I will proceed with a block index, otherwise I'll have to wait for ca. 15hrs till that backup is done.

@KJA1582
Copy link
Contributor Author

KJA1582 commented Apr 9, 2015

Somewhat fixed, checking layout of the new index file, expect PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants