Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More diagnostic info on the large number modulo tests on 32-bit systems #97

Merged
merged 1 commit into from May 2, 2015
Merged

More diagnostic info on the large number modulo tests on 32-bit systems #97

merged 1 commit into from May 2, 2015

Conversation

zmughal
Copy link
Member

@zmughal zmughal commented Apr 9, 2015

No description provided.

@mohawk2
Copy link
Member

mohawk2 commented Apr 9, 2015

Could we also diag the $INT_MAX too?

@mohawk2
Copy link
Member

mohawk2 commented Apr 9, 2015

(done with a sprintf into hex?)

@zmughal
Copy link
Member Author

zmughal commented Apr 9, 2015

Done!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.42% when pulling b70d466 on todo-ops-large-modulo into babaa0e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.42% when pulling b70d466 on todo-ops-large-modulo into babaa0e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.42% when pulling b70d466 on todo-ops-large-modulo into babaa0e on master.

@mohawk2
Copy link
Member

mohawk2 commented Apr 11, 2015

This looks good to me. If Travis (after my rebase/force-push just now) approves, we should merge this.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.4% when pulling fc7bb88 on todo-ops-large-modulo into 5148b8b on master.

@mohawk2 mohawk2 changed the title mark the large number modulo tests as TODO on 32-bit systems More diagnostic info on the large number modulo tests on 32-bit systems May 2, 2015
@mohawk2
Copy link
Member

mohawk2 commented May 2, 2015

My rebase needed me to edit this slightly because @devel-chm has already TODO-ed the relevant tests. Your updates are still useful.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.4% when pulling 881ec36 on todo-ops-large-modulo into 0dabdf2 on master.

@mohawk2 mohawk2 merged commit 881ec36 into master May 2, 2015
@mohawk2 mohawk2 deleted the todo-ops-large-modulo branch May 2, 2015 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zmughal @mohawk2 @coveralls