Feature/depict Part 3 - SVG #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnmay This is aaaaaawesome! |
…clude marked elements.
…timal SVG output. Transformed paths (planned) could also be handled here.
…m generator for formatting or could move the method out of that class.
…iations as atoms.
johnmay
force-pushed
the
feature/depict
branch
from
d5ca332
to
90c882f
Compare
|
Travis was failing - rebased on current master now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving some of the best for last... well there might be more patches but this one is pretty cool. Adds support for reaction titles and an SvgDrawVisitor. The SvgDrawVisitor isn't fully functional (hence non-public) but allows us to write compact SVG and include id and class attributes (thanks to Zach CP for suggestion).
I've included a couple of other fixes for things I saw during testing.
Demo Page: http://cdk.github.io/cdk/1.5/docs/svg/examples.html