put all the temporary jar created by the JRubyClassLoader into on dir…

…ectory these temporary jars get cleaned up after the jvm exits BUT on hard kill the jars do not get cleaned. creating a directory 'jruby-${PID}' might help to clean up easier. Sponsored by Lookout Inc.
jruby · Sep 29, 2015 · 28f6507 · 28f6507
1 parent 94ae555
commit 28f6507
Showing 1 changed file with 19 additions and 1 deletion.
diff --git a/core/src/main/java/org/jruby/util/JRubyClassLoader.java b/core/src/main/java/org/jruby/util/JRubyClassLoader.java
@@ -35,8 +35,10 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
+import java.lang.management.ManagementFactory;
 import java.net.URL;
 import java.net.URLClassLoader;
+import java.nio.file.Files;
 
 import org.jruby.util.log.Logger;
 import org.jruby.util.log.LoggerFactory;
@@ -60,10 +62,26 @@ public class JRubyClassLoader extends ClassDefiningJRubyClassLoader {
 
     private Runnable unloader;
 
+    private File tempdir;
+
     public JRubyClassLoader(ClassLoader parent) {
         super(parent);
     }
 
+    private File getTempDir() {
+        if (tempdir == null) {
+            String processName = ManagementFactory.getRuntimeMXBean().getName();
+            long pid = Long.parseLong(processName.split("@")[0]);
+            File dir = new File(System.getProperty("java.io.tmpdir"), "jruby-" + pid);
+            if (dir.mkdirs()) {
+                dir.deleteOnExit();
+            }
+            ;
+            tempdir = dir;
+        }
+        return tempdir;
+    }
+
     // Change visibility so others can see it
     @Override
     public void addURL(URL url) {
@@ -74,7 +92,7 @@ public void addURL(URL url) {
             OutputStream out = null;
             try
             {
-                File f = File.createTempFile( "jruby", new File(url.getFile()).getName());
+                File f = File.createTempFile("jruby", new File(url.getFile()).getName(), getTempDir());
                 f.deleteOnExit();
                 out = new BufferedOutputStream( new FileOutputStream( f ) );
                 in = new BufferedInputStream( url.openStream() );