Skip to content

Commit

Permalink
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
@@ -342,7 +342,7 @@ public DynamicObject stringCheckNullSafe(DynamicObject string) {

}

@RubiniusPrimitive(name = "string_chr_at")
@RubiniusPrimitive(name = "string_chr_at", lowerFixnumParameters = 1)
public static abstract class StringChrAtPrimitiveNode extends RubiniusPrimitiveNode {

@Child private StringByteSubstringPrimitiveNode stringByteSubstringNode;

4 comments on commit c06ac7c

@nirvdrum
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually working on this at the moment. Lowering fixes the problem, but somewhere a long is leaking where it didn't used to.

@eregon
Copy link
Member Author

@eregon eregon commented on c06ac7c Sep 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, finding out where this long comes from would be very useful.
We should try to get the CI green in between though.

@nirvdrum
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Fixnum#+ overflowed at one point and the node was rewritten.

@eregon
Copy link
Member Author

@eregon eregon commented on c06ac7c Sep 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you find out where it overflowed?
If running without Graal unfortunately Fixnum#+ never splits so it is very likely to happen :(

Sorry, something went wrong.

Please sign in to comment.