We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
headius
Learn more about funding links in repositories.
Report abuse
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
From https://bugs.ruby-lang.org/issues/11548 -
One would expect this method to be called remove_trailing_slash I asked around on IRC and the consensus is this is probably an unfortunate typo that's survived too long. Tailing and Trailing mean similar things, but I think most would expect "trailing" to be the clear choice here. http://ruby-doc.org/stdlib-2.2.3/libdoc/fileutils/rdoc/FileUtils.html#method-i-remove_tailing_slash
One would expect this method to be called remove_trailing_slash
I asked around on IRC and the consensus is this is probably an unfortunate typo that's survived too long.
Tailing and Trailing mean similar things, but I think most would expect "trailing" to be the clear choice here.
http://ruby-doc.org/stdlib-2.2.3/libdoc/fileutils/rdoc/FileUtils.html#method-i-remove_tailing_slash
This may be changing in ruby, I'm thinking JRuby will want to make the change as well.
The text was updated successfully, but these errors were encountered:
Rename #remove_tailing_slash (tailing -> trailing)
8ec6c92
Addresses jruby#3372, repairing the private method name for `FileUtils#remove_tailing_slash` to `FileUtils#remove_trailing_slash`
0d2f510
- Renames FileUtils#remove_tailing_slash (to #remove_trailing_slash) - Addresses jruby#3372, repairing the private method name
Hah, I never noticed this one. Nobu points out it's a private method and can be changed right now, so I'll have a look at your PR.
Sorry, something went wrong.
So your PR is ok. The excludes are strange, because they only exist in the Truffle excludes and I can find no such test in MRI's suite.
I will merge this.
No branches or pull requests
From https://bugs.ruby-lang.org/issues/11548 -
This may be changing in ruby, I'm thinking JRuby will want to make the change as well.
The text was updated successfully, but these errors were encountered: