Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUtils#remove_tailing_slash is a poor method name #3372

Closed
rthbound opened this issue Oct 7, 2015 · 2 comments
Closed

FileUtils#remove_tailing_slash is a poor method name #3372

rthbound opened this issue Oct 7, 2015 · 2 comments
Labels
stdlib
Milestone
JRuby 9.0.2.0

Comments

@rthbound
Copy link
Contributor

rthbound commented Oct 7, 2015

From https://bugs.ruby-lang.org/issues/11548 -

One would expect this method to be called remove_trailing_slash

I asked around on IRC and the consensus is this is probably an unfortunate typo that's survived too long.

Tailing and Trailing mean similar things, but I think most would expect "trailing" to be the clear choice here.

http://ruby-doc.org/stdlib-2.2.3/libdoc/fileutils/rdoc/FileUtils.html#method-i-remove_tailing_slash

This may be changing in ruby, I'm thinking JRuby will want to make the change as well.
rthbound added a commit to rthbound/jruby that referenced this issue Oct 7, 2015
@rthbound
Rename #remove_tailing_slash (tailing -> trailing)

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: CEF2BBFE18BD0E67
Learn about vigilant mode
8ec6c92 
Addresses jruby#3372, repairing the private method name for  `FileUtils#remove_tailing_slash` to `FileUtils#remove_trailing_slash`
rthbound added a commit to rthbound/jruby that referenced this issue Oct 7, 2015
@rthbound
Rename #remove_tailing_slash (tailing -> trailing)
0d2f510 
- Renames FileUtils#remove_tailing_slash (to #remove_trailing_slash)
- Addresses jruby#3372, repairing the private method name
@rthbound rthbound mentioned this issue Oct 7, 2015
Merged
@headius
Copy link
Member

headius commented Oct 8, 2015

Hah, I never noticed this one. Nobu points out it's a private method and can be changed right now, so I'll have a look at your PR.

@headius
Copy link
Member

headius commented Oct 8, 2015

So your PR is ok. The excludes are strange, because they only exist in the Truffle excludes and I can find no such test in MRI's suite.

I will merge this.

@headius headius added this to the JRuby 9.0.2.0 milestone Oct 8, 2015
@headius headius added the stdlib label Oct 8, 2015
@headius headius closed this as completed Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib
Projects
None yet
Milestone
JRuby 9.0.2.0
Development

No branches or pull requests
2 participants
@headius @rthbound