t0141: swap test_sort_cmp() arguments #1790
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
| @@ -27,7 +27,7 @@ test_swarm_filter_cmd() { | |||
| ' | |||
|
|
|||
| test_expect_success "'ipfs swarm filters' output looks good" ' | |||
| test_sort_cmp list_actual list_expected | |||
There was a problem hiding this comment.
This can be all killed in 1 commit.
From grep:
t0141-addfilter.sh
30: test_sort_cmp list_actual list_expected
t0120-bootstrap.sh
37: test_cmp list_actual list_expected
45: test_cmp list2_actual list_expected
66: test_cmp add_actual add_expected
78: test_cmp rm_actual rm_expected
97: test_cmp add2_actual add2_expected
116: test_cmp rm2_actual rm2_expected
t0081-repo-pinning.sh
104: test_cmp actual1 expected1
234: test_cmp actual8 expected8
xt0130-multinode.sh
33: test_cmp actual1 expected1
x0045-add-cat-iptb.sh
33: test_cmp actual1 expected1
|
@chriscool @rht yeah let's do it all in one commit |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Christian Couder chriscool@tuxfamily.org