ensure relative paths from PATH work with -S

just turn the PATH entries into absolute paths before trying to find the given script fixes #3186 Sponsored by Lookout Inc.
jruby · Oct 2, 2015 · 52082d1 · 52082d1
1 parent 3947a2a
commit 52082d1
Showing 4 changed files with 28 additions and 1 deletion.
diff --git a/core/src/main/java/org/jruby/util/cli/ArgumentProcessor.java b/core/src/main/java/org/jruby/util/cli/ArgumentProcessor.java
@@ -571,7 +571,7 @@ private String resolveScript(String scriptName) {
             String path = maybePath.toString();
             String[] paths = path.split(System.getProperty("path.separator"));
             for (int i = 0; i < paths.length; i++) {
-                result = resolve(paths[i], scriptName);
+                result = resolve(new File(paths[i]).getAbsolutePath(), scriptName);
                 if (result != null) return result;
             }
         }

diff --git a/maven/jruby-complete/src/it/integrity/pom.xml b/maven/jruby-complete/src/it/integrity/pom.xml
@@ -198,6 +198,27 @@
               </arguments>
             </configuration>
           </execution>
+          <execution>
+            <id>-S icecream - GH-3186</id>
+            <phase>test</phase>
+            <goals>
+              <goal>exec</goal>
+            </goals>
+            <configuration>
+              <workingDirectory>${basedir}</workingDirectory>
+              <executable>java</executable>
+              <environmentVariables>
+                <PATH>${env.PATH}:somebin</PATH>
+              </environmentVariables>
+              <arguments>
+                <argument>-classpath</argument>
+                <classpath/>
+                <argument>org.jruby.Main</argument>
+                <argument>-S</argument>
+                <argument>icecream</argument>
+              </arguments>
+            </configuration>
+          </execution>
           <execution>
             <id>META-INF/jruby.home is not a file - GH-3342</id>
             <phase>test</phase>

diff --git a/maven/jruby-complete/src/it/integrity/somebin/icecream b/maven/jruby-complete/src/it/integrity/somebin/icecream
@@ -0,0 +1 @@
+puts __FILE__
diff --git a/maven/jruby-complete/src/it/integrity/verify.bsh b/maven/jruby-complete/src/it/integrity/verify.bsh
@@ -53,6 +53,11 @@ if ( !log.contains( expected ) )
 {
     throw new RuntimeException( "log file does not contain '" + expected + "'" );
 }
+expected = basedir + "/somebin/icecream";
+if ( !log.contains( expected ) )
+{
+    throw new RuntimeException( "log file does not contain '" + expected + "'" );
+}
 
 expected = "jruby home is a file: falsefalse";
 if ( !log.contains( expected ) ) throw new RuntimeException( "log file does not contain '" + expected + "'" );